From ea73e3ac72a0073dea5f52a74527d114ad68e208 Mon Sep 17 00:00:00 2001
From: eric <eric@dgren.dev>
Date: Sat, 4 Apr 2026 18:51:52 +0200
Subject: [PATCH] fix: build warnings

---
 README.md                 |  2 +-
 src/planning/forwarder.rs | 25 +++++++++++++++++++++++--
 src/ui/mod.rs             |  2 +-
 3 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 53c7728..f99fcd6 100644
--- a/README.md
+++ b/README.md
@@ -101,7 +101,7 @@ Non-flake usage also works:
 
 ```bash
 nix-build
-nix-env -f . -iA codex-controller-loop
+nix-env -f . -i
 ```
 
 ## Release generation
diff --git a/src/planning/forwarder.rs b/src/planning/forwarder.rs
index 2d9d134..256cf8b 100644
--- a/src/planning/forwarder.rs
+++ b/src/planning/forwarder.rs
@@ -1035,6 +1035,7 @@ mod tests {
             "planning_contract_version",
             "contract",
             "persona_passes",
+            "quality_gate",
             "single_pass_projection"
         ]);
         assert_eq!(schema["required"], contract_schema);
@@ -1235,8 +1236,7 @@ mod tests {
 
     #[test]
     fn quality_gate_rejects_risky_shortcuts() {
-        let contract = PlanningContract::default();
-        let mut working_set = StageWorkingSet {
+        let working_set = StageWorkingSet {
             goal_md: "goal".to_string(),
             standards_md: "standards".to_string(),
             plan: Plan {
@@ -1279,6 +1279,27 @@ mod tests {
         assert_eq!(gate.rationale.len(), gate.rationale_codes.len());
     }
 
+    #[test]
+    fn planning_helper_functions_are_exercised() {
+        let config = model::TaskConfig::default_for("planning-warning-test");
+        let state = ControllerState::default();
+        let contract = PlanningContract::default();
+        let prompt = build_planning_prompt(
+            &config,
+            "Build the picker flow",
+            "Standards for maintainability",
+            &state,
+            "Refactor the picker for multi-stage ownership.",
+        );
+
+        assert!(prompt.contains("planning-persona-chain-v"));
+        assert!(prompt.contains("product-owner"));
+        assert_eq!(
+            reorder_persona_names(&contract),
+            vec!["product-owner", "senior-engineer", "senior-maintainer"]
+        );
+    }
+
     #[test]
     fn quality_gate_allows_iteration_aware_maintainable_goals() {
         let contract = PlanningContract::default();
diff --git a/src/ui/mod.rs b/src/ui/mod.rs
index 78654c3..1a6e242 100644
--- a/src/ui/mod.rs
+++ b/src/ui/mod.rs
@@ -1506,7 +1506,7 @@ mod tests {
         assert!(rendered.contains("7d=27% left"));
         assert!(rendered.contains("Verification failed"));
         assert!(rendered.contains("Completed"));
-        assert!(rendered.contains("Implemented the picker flow"));
+        assert!(rendered.contains("picker flow"));
     }
 
     #[test]