From 76fad7e9c84c415119ef2418343716bdd8603dd0 Mon Sep 17 00:00:00 2001
From: Eric <eric@dgren.dev>
Date: Wed, 4 Mar 2026 07:54:06 +0000
Subject: [PATCH] chore: address phase 7 review feedback

---
 bun/extensions.bzl                                   | 2 +-
 tests/install_extension_test/extension_shape_test.sh | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/bun/extensions.bzl b/bun/extensions.bzl
index cb25371..f9624f6 100644
--- a/bun/extensions.bzl
+++ b/bun/extensions.bzl
@@ -57,7 +57,7 @@ bun = module_extension(
 
 _install = tag_class(
     attrs = {
-        "name": attr.string(default = "node_modules"),
+        "name": attr.string(mandatory = True),
         "package_json": attr.string(mandatory = True),
         "bun_lockfile": attr.string(mandatory = True),
     },
diff --git a/tests/install_extension_test/extension_shape_test.sh b/tests/install_extension_test/extension_shape_test.sh
index a2f9aa1..94fef31 100755
--- a/tests/install_extension_test/extension_shape_test.sh
+++ b/tests/install_extension_test/extension_shape_test.sh
@@ -3,7 +3,8 @@ set -euo pipefail
 
 extension_file="$1"
 
-grep -q 'bun_install = module_extension(' "${extension_file}"
-grep -q 'tag_classes = {"install": _install}' "${extension_file}"
-grep -q '"package_json": attr.string(mandatory = True)' "${extension_file}"
-grep -q '"bun_lockfile": attr.string(mandatory = True)' "${extension_file}"
+grep -Eq 'bun_install[[:space:]]*=[[:space:]]*module_extension\(' "${extension_file}"
+grep -Eq 'tag_classes[[:space:]]*=[[:space:]]*\{"install":[[:space:]]*_install\}' "${extension_file}"
+grep -Eq '"name":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"
+grep -Eq '"package_json":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"
+grep -Eq '"bun_lockfile":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"