eric/rules_bun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: address phase 7 review feedback

Browse Source
This commit is contained in:
Eric
2026-03-04 07:54:06 +00:00
parent f367aab629
commit de5a434433
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bun/extensions.bzl
View File

@@ -57,7 +57,7 @@ bun = module_extension(
_install = tag_class(
attrs = {
"name": attr.string(default = "node_modules"),
"name": attr.string(mandatory = True),
"package_json": attr.string(mandatory = True),
"bun_lockfile": attr.string(mandatory = True),
},

9
tests/install_extension_test/extension_shape_test.sh
View File

@@ -3,7 +3,8 @@ set -euo pipefail
extension_file="$1"
grep -q 'bun_install = module_extension(' "${extension_file}"
grep -q 'tag_classes = {"install": _install}' "${extension_file}"
grep -q '"package_json": attr.string(mandatory = True)' "${extension_file}"
grep -q '"bun_lockfile": attr.string(mandatory = True)' "${extension_file}"
grep -Eq 'bun_install[[:space:]]*=[[:space:]]*module_extension\(' "${extension_file}"
grep -Eq 'tag_classes[[:space:]]*=[[:space:]]*\{"install":[[:space:]]*_install\}' "${extension_file}"
grep -Eq '"name":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"
grep -Eq '"package_json":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"
grep -Eq '"bun_lockfile":[[:space:]]*attr\.string\(mandatory[[:space:]]*=[[:space:]]*True\)' "${extension_file}"